Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplot returns the artist it adds. #2781

Merged
merged 1 commit into from Feb 10, 2014
Merged

Triplot returns the artist it adds. #2781

merged 1 commit into from Feb 10, 2014

Conversation

GBillotey
Copy link
Contributor

Did this because of:
http://stackoverflow.com/questions/20954242/clear-triplot-from-figure

I took also this opportunity to fix triplot calls like:

 plt.triplot(triang, 'bo-', ms=9)

which previously didn't work.

@tacaswell
Copy link
Member

Looks good, but could you elaborate on why these change fixes the the calls with fmt?

The change to inserting nan makes the code much more readable.

@GBillotey
Copy link
Contributor Author

Thank you. I should have put it more clearly:

Previously, the calls with fmt already worked as expected ; however the kwargs were passed to both PathPatch and plot resulting in errors for those unsupported by PathPatch (like ms). Now all the drawing is handled by plot ; it is consistent with triplot documentation and should be more future-proof, I hope.

@ianthomas23
Copy link
Member

Looks good to me, and doesn't seem to break anything. Travis error unrelated. Thanks @GBillotey.

ianthomas23 added a commit that referenced this pull request Feb 10, 2014
Triplot returns the artist it adds.
@ianthomas23 ianthomas23 merged commit a4d4031 into matplotlib:master Feb 10, 2014
@GBillotey
Copy link
Contributor Author

Thanks @ianthomas23 for the merge, and for the implementation advice as well.

@GBillotey GBillotey deleted the return_triplot branch February 12, 2014 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants