WebAgg: Fix IPython detection. Fix encoding error on Python 3 #2834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2832.
This fixes an error on Python 3 where byte strings can not be serialized to JSON.
This also removes
show()
as a way to display all figures inline in the IPython notebook. This causes problems because:In a regular IPython console, you want to start the plotting server blocking
In an IPython notebook, you don't
There is no way to detect which frontend you have for IPython -- in some cases, you may actually be using both.
So the solution here is to make
show()
always start a blocking server (and thus, it's only useful outside of the IPython notebook), and use theFigure
repr to display an inline figure.