Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ccw pie test #2897

Closed
tacaswell opened this issue Mar 13, 2014 · 4 comments
Closed

add ccw pie test #2897

tacaswell opened this issue Mar 13, 2014 · 4 comments
Assignees
Milestone

Comments

@tacaswell
Copy link
Member

add test for #2853

@tacaswell tacaswell added this to the v1.4.0 milestone Mar 13, 2014
@tacaswell tacaswell self-assigned this Mar 13, 2014
@sfroid
Copy link
Contributor

sfroid commented Mar 26, 2014

@tacaswell
Thomas... are we looking for an image test for this one?
Also, from the other pie based bug I wrote tests for (#2923), you commented that we might only need a png test and can ignore the svg and pdf files.

How do I ignore the svg/pdf files? Can I just leave them out from the commit? Wouldn't that lead to failed tests?

@tacaswell
Copy link
Member Author

Yes, we are looking for an image test here.

You can specify which extensions to test by passing the extensions kwarg to the decorator:

@image_comparison(..., extensions=['png'])
def test_blah(..)
     pass

See the function in testing.decorators for all of the parameters.

sfroid added a commit to sfroid/matplotlib that referenced this issue Mar 28, 2014
@sfroid
Copy link
Contributor

sfroid commented Mar 28, 2014

@tacaswell
I started creating the tests but then I thought I made an error, where I branched the fix off the master. I believed that I should have branched it off 1.4.0 or 1.4.x. Then I noticed that there is no 1.4.0 or 1.4.x branch. Should I branch off the master?

@tacaswell
Copy link
Member Author

Yes, work off of master. We have not cut 1.4 yet.

sfroid added a commit to sfroid/matplotlib that referenced this issue Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants