Fixes a bug in drawing bitmap images in the macosx backend for handling device scaling #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the bug identified in issue #2937 |
|
@mdehoon Can you take a look at this? |
|
Looks good to me. |
tacaswell
added a commit
that referenced
this pull request
Apr 3, 2014
Fixes a bug in drawing bitmap images in the macosx backend for handling device scaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation does not take into account any transforms being applied to user space and will result in wrong sizes for the CGRect being passed to CGContextDrawImage. This fixes that bug while maintaining the device scaling support used for hi-resolution (retina) displays.