New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in y-minimum for weighted, log, stepped Axes.hist
#2945
Comments
What version did you test this on? |
1.3.1 (macports) and 1.4.x (HEAD of master). |
@duncanmmacleod Could you put that patch in a PR please? @neggert Do you have time to look at this (sorry to keep pestering you, but you are in my brain as the current histogram expert)? |
Yup, looks like that patch should do the trick. Just need a PR for it. If you could modify one of the existing histogram tests to pick this up, that would be good. @tacaswell No problem. |
closed by #3089 |
P.S. That is a good thing @tacaswell - @neggert has done some great work on this aspect of mpl and is rightfully the "mpl histogram expert". 👍 😄 |
I think there is a bug in
Axes.hist
for the specific combination oflog=True, histtype='step{filled}', weights=[something small]
, where the y-minimum is set to 1/base despite the possibility of weights << 1. Please see the following example:with
log=False
, the figure looks normal, while withlog=True
the patch minimum is set to0.1
(> 1e-5) meaning the patches are all 1-D lines at 0.1.I believe this patch should fix the problem.
The text was updated successfully, but these errors were encountered: