BUG : turned clipping off on pie chart components #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you maybe explain why this is better than just adjust the hardcoded limits by a small amount? |
|
I think this is better than adjusting the limits because now the patches and the text match clipping behavior. It would be better to control this via kwarg (not hard coded) for both the text and the wedges. I will take care of that when I rebase. |
|
@Tillsten Changed to leveraging the newly added *props dicts. |
|
Could you also link the PR where the dict was added? Still one question left (see commit coment). If the answer is no, LGTM. Thanks again for you work! |
|
The dicts were added in #2923 |
|
You are right, it copys the props, so LGTM from me. |
- set default value of `clip_on` in *prop dicts - closes matplotlib#2518
WeatherGod
added a commit
that referenced
this pull request
Jul 6, 2014
BUG : turned clipping off on pie chart components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2518
This should probably get a test, https://stackoverflow.com/questions/19347453/matplotlib-savefig-trims-the-graph should be a good base.