BUG: Fix the triangular marker rendering error. #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thank you for the PR. Can you add an entry to CHANGELOG and make the commit message a bit more descriptive? @NelleV I think an image test with large symbols would not be too bad to write. |
mpyrozhok
changed the title
instead of "Right" triangle and vice-versa.
|
I've updated CHANGELOG and commit message. BTW here is the test picture with fix applied: |
tacaswell
added a commit
that referenced
this pull request
Apr 11, 2014
BUG: Fix the triangular marker rendering error. Closes #2964
|
Merged with out a test, there probably should be a single test for all of the marker styles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2964.