Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG : expand x/y range in hexbin if singular #3038

Merged
merged 1 commit into from May 8, 2014

Conversation

tacaswell
Copy link
Member

  • ensures sensible behavior if a list of identical values is passed
    to hexbin

Closes #2863

@@ -3762,6 +3763,10 @@ def hexbin(self, x, y, C=None, gridsize=100, bins=None,
xmax = np.amax(x)
ymin = np.amin(y)
ymax = np.amax(y)
# to avoid issues with singular data, expand the mim/max pairs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: min/max

@tacaswell tacaswell added this to the v1.4.0 milestone May 3, 2014
@cleanup
def test_pathological_hexbin():
# issue #2863
with warnings.catch_warnings(True) as w:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you need to use a kwarg, "record=True". Based on the docs, it will work for python 2, and the Travis failure indicates it is required for python 3. That seems strange, but there it is.

 - ensures sensible behavior if a list of identical values is passed
   to hexbin

Closes matplotlib#2863
@tacaswell
Copy link
Member Author

@efiring fixed and squashed. The test failure is the font priority issue.

efiring added a commit that referenced this pull request May 8, 2014
BUG : expand x/y range in hexbin if singular
@efiring efiring merged commit 1472dfc into matplotlib:master May 8, 2014
@tacaswell tacaswell deleted the hexbin_singular branch May 8, 2014 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure non-singular extent in hexbin
3 participants