Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to get_window_extent #3055

Closed
tacaswell opened this issue May 9, 2014 · 5 comments · Fixed by #3184
Closed

Add warning to get_window_extent #3055

tacaswell opened this issue May 9, 2014 · 5 comments · Fixed by #3184
Milestone

Comments

@tacaswell
Copy link
Member

Add warning of unexpected behavior when using get_window_extent to get the size of rendered artists in screen-units. See #2831 .

@tacaswell tacaswell added this to the v1.4.0 milestone May 9, 2014
@pelson
Copy link
Member

pelson commented May 20, 2014

I'm not sure I agree with this. Adding the warning will not give us anything new, other than an annoying warning. A known bug doesn't necessarily have to emit a warning as far as I'm concerned...

@efiring
Copy link
Member

efiring commented May 20, 2014

@pelson, I think @tacaswell is suggesting a warning somewhere in the documentation, not a warning to be emitted by the code.

@tacaswell
Copy link
Member Author

Yes, I mean to put a note in the documentation, not to emit a warning.
On May 20, 2014 2:04 PM, "Eric Firing" notifications@github.com wrote:

@pelson https://github.com/pelson, I think @tacaswellhttps://github.com/tacaswellis suggesting a warning somewhere in the documentation, not a
warning to be emitted by the code.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3055#issuecomment-43661948
.

@tacaswell
Copy link
Member Author

Also, this issue my be unneeded if the patch from @leejjoon in PR #3054 cleans up all of these issues.

It is easier to do-in an extra issue than remember one that does not exist 😉

@pelson
Copy link
Member

pelson commented May 21, 2014

Ah. Thanks @tacaswell & @efiring - got the wrong end of the stick. 👍 after all 😉

tacaswell added a commit to tacaswell/matplotlib that referenced this issue Jul 4, 2014
joferkington pushed a commit to joferkington/matplotlib that referenced this issue Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants