Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: restore default boxplot style and respect for the sym kwarg #3066

Closed

Conversation

phobson
Copy link
Member

@phobson phobson commented May 16, 2014

Closes #3042

I think I'm getting some weird test failures. Still need to track that down.

When an element of *usermedians* == None, the median will be
computed by matplotlib as normal.
When an element of *usermedians* == None, the median will be
cted by matplb as normal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange abbreviation

@tacaswell
Copy link
Member

If you want to change the api and defaults for bxp go right ahead, it is just the defaults when called via boxplot that can't change. You can put the logic to generate the old defaults in boxplot and pass them through to bxp. You have to write the default handling code twice, but it makes everyone happy(ish).

@tacaswell tacaswell added this to the v1.4.0 milestone May 16, 2014
@phobson
Copy link
Member Author

phobson commented May 16, 2014

Thanks for the feedback, Thomas.

Looks like I fell victim to my crappy trackpad randomly highlighting and
text as I was typing that out on a recent flight. Will fix soon.

On Fri, May 16, 2014 at 5:57 AM, Thomas A Caswell
notifications@github.comwrote:

If you want to change the api and defaults for bxp go right ahead, it is
just the defaults when called via boxplot that can't change. You can put
the logic to generate the old defaults in boxplot and pass them through
to bxp. You have to write the default handling code twice, but it makes
everyone happy(ish).


Reply to this email directly or view it on GitHubhttps://github.com//pull/3066#issuecomment-43327753
.

@tacaswell
Copy link
Member

Figured it was something like that.

I feel you on issues with trackpads...

@tacaswell
Copy link
Member

@phobson Any progress on this?

@phobson
Copy link
Member Author

phobson commented May 29, 2014

Will wrap up this weekend. Promise. --
Paul Hobson
Sorry if this is unintelligible. I'm on my phone.

On Wed, May 28, 2014 at 9:04 PM, Thomas A Caswell
notifications@github.com wrote:

@phobson Any progress on this?

Reply to this email directly or view it on GitHub:
#3066 (comment)

@tacaswell
Copy link
Member

@phobson Thoughts on the test failures?

@phobson
Copy link
Member Author

phobson commented Jun 10, 2014

I spent a lot of time troubleshooting them.

  1. stackplot is failing in all cases, so hopefully a rebase will fix that.
  2. I narrowed it down to the tests that involved horizontal boxplots.

What's weird is that enabling those tests cause failures in unrelated
boxplot/bxp tests. Comment them out, only test_stackplot fails.

Still wrapping my brain around this.

On Mon, Jun 9, 2014 at 6:05 PM, Thomas A Caswell notifications@github.com
wrote:

@phobson https://github.com/phobson Thoughts on the test failures?


Reply to this email directly or view it on GitHub
#3066 (comment)
.

@tacaswell
Copy link
Member

do they also fail if you run the tests in series? What do the test images look like?

@tacaswell
Copy link
Member

@phobson I am somewhat confused, there is a lot more new code in this than I expected there to be. Why did capprops and whiskerprops get added?

@tacaswell
Copy link
Member

@phobson The issue is that the doplot function expects that *args will have an even length (so that the shuffling works correctly), but when do_plot is used for the fliers sym is also passed in as a positional argument so the length of args is odd which is the source of the errors.

The rest of the fails were taken care of by a re-base.

@tacaswell
Copy link
Member

closing this in favor of #3165 for tidyness. We can always re-open this one/close that one later.

@tacaswell tacaswell closed this Jun 28, 2014
@phobson phobson deleted the bug-restore-boxplot-defaults branch March 28, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: needs revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boxplot does not take parameters into account
2 participants