BUG : patches.Wedge.set_radius set wrong attribute #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For Python 2.6, maybe enclosing the generator comprehension in parentheses will solve the problem. Parentheses around the (k, v) wouldn't hurt either, but don't address the immediate problem. |
|
Looks like we just have to use https://stackoverflow.com/questions/1747817/python-create-a-dictionary-with-list-comprehension |
set_radius set the attribute `radius` which is not used to compute the path. Change to set `self.r` which is used.
WeatherGod
added a commit
that referenced
this pull request
Jul 6, 2014
BUG : patches.Wedge.set_radius set wrong attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_radius set the attribute
radiuswhich is notused to compute the path. Change to set
self.rwhichis used.