Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC : sixify unichr #3131

Merged
merged 2 commits into from Jun 10, 2014
Merged

DOC : sixify unichr #3131

merged 2 commits into from Jun 10, 2014

Conversation

tacaswell
Copy link
Member

closes #3117

@tacaswell tacaswell added this to the v1.4.0 milestone Jun 9, 2014
@tacaswell
Copy link
Member Author

replaced commit to correct which PR this points at.

@@ -19,10 +19,10 @@
import zlib

import numpy as np
from six import unichr

if six.PY3:
from io import BytesIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using six.BytesIO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure and was doing this on the train, fixed now.

@pelson
Copy link
Member

pelson commented Jun 10, 2014

👍

pelson added a commit that referenced this pull request Jun 10, 2014
@pelson pelson merged commit 0b481b5 into matplotlib:master Jun 10, 2014
@tacaswell tacaswell deleted the unichr_cleanup branch June 10, 2014 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt4 backend using unichr() in python3
3 participants