Whats new cleaning #3227
Merged
Whats new cleaning #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * matplotlib now uses a less-aggressive call to ``gc.collect(1)`` when | ||
| closing figures to avoid major delays with large numbers of user objects | ||
| in memory. You may want to manually call ``gc.collect()`` if you are worried | ||
| about stray matplotlib object.s |
There was a problem hiding this comment.
typo at the end of this sentence. Also, I really think this should be coached carefully. I don't want to see a proliferation of gc.collect() calls by people prematurely optimizing. Perhaps a little bit of context would be needed?
There was a problem hiding this comment.
It's possible we could just take out the second sentence altogether, unless there are true situations in which it is required/helps. I'm not sure there are, but maybe I'm just not aware of them...
There was a problem hiding this comment.
I think people who need it just know about it, so I am 👍 for removing that last sentence.
|
I probably should squash these down before it gets merged. |
|
If you can squash these down, I'll merge. |
|
@NelleV Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing whats_new and api_changes entries.