Use libpng-config if available #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are some extra commits in this PR. Can you make sure it only contains your libpng-related stuff (probably rebasing on the current master will be sufficient). |
|
Looks good otherwise... |
|
Yeah, I am sorry... I am a noob at GitHub =D |
|
No worries! I certainly have stories to tell when I was getting used to it. Welcome. |
tacaswell
added a commit
that referenced
this pull request
Aug 26, 2014
BLD : Use libpng-config if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use alt_exec to pass libpng-config with ldflags argument.
Also duplicated versioning ability as freetype class performs it. This allows for pretty config summary.