Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error with QSizePolicy #3322

Merged
merged 1 commit into from Aug 6, 2014
Merged

Conversation

stlehmann
Copy link

Changed QtGui.QSizePolicy to QtWidgets.SizePolicy as the namepace has changed from Qt4 to Qt5.

Changed QtGui.QSizePolicy to QtWidgets.SizePolicy as the namepace has changed from Qt4 to Qt5
@tacaswell tacaswell added this to the v1.4.x milestone Jul 29, 2014
@tacaswell
Copy link
Member

@mfitzp Can you take a look at this?

@tacaswell tacaswell modified the milestones: v1.4.x, v1.4.0 Jul 29, 2014
@tacaswell
Copy link
Member

This should also be cherry-picked back for 1.4.0.

@mfitzp
Copy link
Member

mfitzp commented Aug 1, 2014

This looks fine to me, QSizePolicy was missed in the conversion to the new Qt5 module layout.

@jenshnielsen
Copy link
Member

Will this work with the Qt4 backend which is a shim on top of this?

@mfitzp
Copy link
Member

mfitzp commented Aug 1, 2014

Yep, the shim assigns QtWidgets = QtGui in qt_compat.py. This means that the Qt5 module structure can safely be used with both Qt4 and Qt5 interfaces.

tacaswell added a commit that referenced this pull request Aug 6, 2014
Fixed error with QSizePolicy
@tacaswell tacaswell merged commit 31a0af5 into matplotlib:master Aug 6, 2014
tacaswell added a commit that referenced this pull request Aug 28, 2014
Fixed error with QSizePolicy
@tacaswell
Copy link
Member

cherry-picked as 9891b67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants