Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LassoSelector could implement {set,get}_active #3375

Closed
anntzer opened this issue Aug 17, 2014 · 2 comments
Closed

LassoSelector could implement {set,get}_active #3375

anntzer opened this issue Aug 17, 2014 · 2 comments
Milestone
v2.1

Comments

@anntzer
Copy link
Contributor

anntzer commented Aug 17, 2014

RectangleSelector implements {set,get}_active which just set the .active attribute. They could also be implemented in LassoSelector, or perhaps a common base class.
@tacaswell tacaswell added this to the v1.5.x milestone Aug 17, 2014
@tacaswell
Copy link
Member

Would you like to take a crack at this?

anntzer added a commit to anntzer/matplotlib that referenced this issue Aug 17, 2014
@anntzer
Move widget.{get,set}_active to AxisWidget.
13ce609 
The method was previously defined only for RectangleSelectors (matplotlib#3375).

Also, an redundant line was removed (RectangleSelectors are already set
active on __init__ by the superclass).
@anntzer anntzer mentioned this issue Aug 17, 2014
Merged
@tacaswell
Copy link
Member

Closed by #3376.

Please ping me if I am confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
2 participants
@tacaswell @anntzer