Only insert links to pdfs if we are actually generating these. #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould silence most warnings in the html only small build on travis
|
👍 |
|
Looks like it worked. The number of Sphinx warnings is down from over 800 to 57. An important thing to check in the review is that I haven't broken anything in the pdf output which travis does not test at all |
tacaswell
added a commit
that referenced
this pull request
Sep 18, 2014
BUG : Only insert links to pdfs if we are actually generating these.
|
The pdf has some other pathologies, but the outputs before and after this patch are nearly identical. |
|
At last! Thanks @jenshnielsen! |
This was referenced Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should silence most warnings in the html only small build on Travis. Waiting for Travis to confirm