Fixed the differencing of images for the webagg/nbagg backends. #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pelson
force-pushed
the
nbagg_diff_image_fix
branch
from
0e3a06f
to
2616fed
Compare
pelson
force-pushed
the
nbagg_diff_image_fix
branch
from
2616fed
to
b30d50d
Compare
| @@ -86,24 +92,41 @@ def draw(self): | |||
| def draw_idle(self): | |||
| self.send_event("draw") | |||
|
|
|||
| def set_image_mode(self, mode): | |||
There was a problem hiding this comment.
Should this be done as a property?
There was a problem hiding this comment.
Could do. There is a performance cost to using properties over methods, but I agree, it would be a more pleasant interface. Having said that, I was very tempted to put a leading underscore in the name as it is a pretty useless interface unless you are developing some code in get_diff_image...
mdboom
added a commit
that referenced
this pull request
Sep 27, 2014
Fixed the differencing of images for the webagg/nbagg backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3552 I improved the ability to handle images with transparency in the webagg/nbagg backends. Unfortunately, in doing so, I managed to break the differencing mode by always clearing the existing image on the javascript side. This change fixes the issue by keeping track of the image mode in the backend and notifying the client of any changes (as a result of transparency appearing).