Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a weird thing in the source code comments #3948

Closed
argriffing opened this issue Dec 27, 2014 · 5 comments
Closed

a weird thing in the source code comments #3948

argriffing opened this issue Dec 27, 2014 · 5 comments
Assignees
Milestone

Comments

@argriffing
Copy link

This url in the source code is out of control

http://groups.google.com/groups?hl=en&lr=&threadm=mailman.5090.1098044946.5135.python-list%40python.org&rnum=1&prev=/groups%3Fq%3D__doc__%2Bauthor%253Ajdhunter%2540ace.bsd.uchicago.edu%26hl%3Den%26btnG%3DGoogle%2BSearch

@pelson
Copy link
Member

pelson commented Dec 27, 2014

It relates to a problem with python 2.2. I think we are now only supporting 2.6 onwards - so it might be time to refactor this bit of code anyhow.

@tacaswell tacaswell added this to the v1.5.x milestone Dec 27, 2014
@pganssle
Copy link
Member

If I'm right about what he's referring to, MEP13, if implemented, would replace these get_ and set_ methods with properties anyway.

Either way, though, the URL seems to be dead, and I can't find an archive of the particular message anywhere, so it's not clear that it's doing much in the source code as is.

@WeatherGod
Copy link
Member

Link rot sucks. We should double-check for other links that may be more
susceptible to link-rot (although I am surprised at losing a google groups
message).

On Sat, Dec 27, 2014 at 1:17 PM, Paul G. notifications@github.com wrote:

If I'm right about what he's referring to, MEP13
https://github.com/matplotlib/matplotlib/wiki/MEP13, if implemented,
would replace these get_ and set_ methods with properties anyway.

Either way, though, the URL seems to be dead, and I can't find an archive
of the particular message anywhere, so it's not clear that it's doing much
in the source code as is.


Reply to this email directly or view it on GitHub
#3948 (comment)
.

@tacaswell
Copy link
Member

This https://mail.python.org/pipermail/python-list/2004-October/255696.html may be the discussion in question.

It looks like that url is actually a search query and google has sense changed their internal api...

@WeatherGod
Copy link
Member

Might make sense to fix this in PR #3949

On Mon, Dec 29, 2014 at 10:18 PM, Thomas A Caswell <notifications@github.com

wrote:

This
https://mail.python.org/pipermail/python-list/2004-October/255696.html
may be the discussion in question.

It looks like that url is actually a search query and google has sense
changed their internal api...


Reply to this email directly or view it on GitHub
#3948 (comment)
.

tacaswell added a commit to tacaswell/matplotlib that referenced this issue Feb 15, 2016
Given that it is do a thread about the limitation of python 2.2 we
should revisit some of these choices.

closes matplotlib#3948
@tacaswell tacaswell self-assigned this Feb 15, 2016
tacaswell added a commit to tacaswell/matplotlib that referenced this issue May 22, 2016
Given that it is to a thread about the limitation of python 2.2 we
should revisit some of these choices.

closes matplotlib#3948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants