Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path effects applied to annotation text containing \n #4024

Closed
dkirkby opened this issue Jan 21, 2015 · 4 comments · Fixed by #5217
Closed

Path effects applied to annotation text containing \n #4024

dkirkby opened this issue Jan 21, 2015 · 4 comments · Fixed by #5217
Assignees
@mdboom
Labels
status: confirmed bug topic: text
Milestone
v2.1

Comments

@dkirkby
Copy link

dkirkby commented Jan 21, 2015

I am using the following test program with mathplotlib 1.4.0 (via anaconda) on OS X 10.10.1:

import matplotlib.pyplot as plt
import matplotlib.patheffects as pe

plt.subplot(1,1,1)
plt.annotate('line1\nline2',xy=(0.5,0.5),xycoords='axes fraction',fontsize='x-large',
    path_effects=[pe.withStroke(linewidth=1,foreground='r')])
plt.show()

This fails with:

AttributeError: GraphicsContextBase instance has no attribute 'draw_path'

Removing the \n from the text or removing the path_effects option both run as expected. Any workarounds you can suggest are appreciated.
@tacaswell tacaswell added this to the v1.5.x milestone Jan 22, 2015
@cimarronm
Copy link
Contributor

Definitely a problem with the MacOS backend and probably affects other backends which use a stack-based graphics context

This was referenced Mar 8, 2015
Merged
Closed
@cimarronm
Copy link
Contributor

@dkirkby This should be resolved with PR #4201 and #4202.

The workaround without these fixes applied is to separate out the annotation into separate annotations (without the newline).

@tacaswell tacaswell modified the milestones: next point release, proposed next point release May 15, 2015
@mdehoon mdehoon mentioned this issue Jun 16, 2015
Closed
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Jun 19, 2015
@tacaswell
FIX: implement get_rgb for GraphicsContextCairo
857a49c 
Was falling back to the base implementation of get_rgb which looks at a
local variable which was getting out of sync with the stack.  Now
consults the underlying cairo context.

Closes matplotlib#4024 for cairo based backends
@jenshnielsen jenshnielsen mentioned this issue Jul 9, 2015
Closed
@jenshnielsen
Copy link
Member

I don't think this is fixed for OSX so I will reopen #4542 fixed it for Cairo which caused this to auto close

@jenshnielsen jenshnielsen reopened this Aug 6, 2015
@tacaswell tacaswell modified the milestones: proposed next point release, next point release Aug 9, 2015
@tacaswell
Copy link
Member

not blocking 1.5 on this unless @mdehoon wants to.

@tacaswell tacaswell mentioned this issue Sep 12, 2015
Closed
mdboom added a commit to mdboom/matplotlib that referenced this issue Oct 9, 2015
@mdboom
Fix PathEffect rendering on some backends
bfab80e 
The special sub-GC that is created by the PathEffectRenderer was of
GraphicsContextBase, rather than the backend-specific GC.

Fix matplotlib#5049, Fix matplotlib#4024
@mdboom mdboom mentioned this issue Oct 9, 2015
Merged
@mdboom mdboom assigned mdboom and unassigned cimarronm Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdboom mdboom

Labels
status: confirmed bug topic: text
Projects
None yet
Milestone
v2.1
5 participants
@mdboom @dkirkby @tacaswell @jenshnielsen @cimarronm