Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curves, line & axis parameter editor has poor support for colors #4410

Closed
anntzer opened this issue May 6, 2015 · 1 comment · Fixed by #4411
Closed

Curves, line & axis parameter editor has poor support for colors #4410

anntzer opened this issue May 6, 2015 · 1 comment · Fixed by #4411

Comments

@anntzer
Copy link
Contributor

anntzer commented May 6, 2015

In [1]: plot([1, 2], color=(.75, .25, .25)) # <- normal reddish color

Select the parameter editor (green tick) and directly click ok. The line becomes black. In fact, if you check the Curves panel, the color editor gives #000000 as color. A quick look at formlayout.py shows that to_qcolor simply casts the color attribute to a string (so "(0.75, 0.25, 0.25)" in our case) and parses it as hex, giving up and returning black if it doesn't look like a hex RGB.

@tacaswell tacaswell added this to the proposed next point release milestone May 6, 2015
tacaswell added a commit to tacaswell/matplotlib that referenced this issue May 6, 2015
Convert all line colors to hex before passing into the form layout.

Closes matplotlib#4410
@tacaswell
Copy link
Member

This should also be fixed in #4411

@QuLogic QuLogic modified the milestones: v1.5.0, 2.1 (next point release) Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants