Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_axes:test_rc_grid image comparison test has always been broken #5535

Closed
mdboom opened this issue Nov 20, 2015 · 1 comment
Closed

test_axes:test_rc_grid image comparison test has always been broken #5535

mdboom opened this issue Nov 20, 2015 · 1 comment
Assignees
@QuLogic
Milestone
v1.5.1

Comments

@mdboom
Copy link
Member

mdboom commented Nov 20, 2015

In #5307, where I am lowering our testing tolerance down to zero, I am discovering a few recent changes that slipped through because the tolerance on our tests was too high.

As it turns out the test_axes:test_rc_grid test has always been broken since it was first added in 94d044e.

BASELINE IMAGE:

rc_grid-expected

ACTUAL RESULT:

rc_grid

@olgabot: Any thoughts about what might be up here?
@mdboom mdboom added this to the next major release (2.0) milestone Nov 20, 2015
@QuLogic
Copy link
Member

QuLogic commented Dec 3, 2015

Axes grids are disabled by default. The overriding dicts need to also contain axes.grid: True.

@QuLogic QuLogic mentioned this issue Dec 3, 2015
Merged
@QuLogic QuLogic self-assigned this Dec 3, 2015
@QuLogic QuLogic closed this as completed in 8e7e7db Dec 3, 2015
@QuLogic QuLogic modified the milestones: Critical bugfix release (1.5.1), next major release (2.0) Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuLogic QuLogic

Labels
None yet
Projects
None yet
Milestone
v1.5.1
Development

No branches or pull requests
2 participants
@mdboom @QuLogic