Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logformatting for non integer bases. #960

Merged
merged 2 commits into from Aug 3, 2012

Conversation

pelson
Copy link
Member

@pelson pelson commented Jun 20, 2012

Fixes #909.

@@ -567,9 +567,8 @@ class LogFormatter(Formatter):
"""
Format values for log axis;

if attribute *decadeOnly* is True, only the decades will be labelled.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true:

$> grep -ir decadeOnly *
Binary file doc/build/doctrees/api/ticker_api.doctree matches
doc/build/html/api/ticker_api.html:<p>if attribute <em>decadeOnly</em> is True, only the decades will be labelled.</p>
lib/matplotlib/ticker.py:    if attribute *decadeOnly* is True, only the decades will be labelled.
lib/matplotlib/ticker.py:        self.decadeOnly = True

@pelson
Copy link
Member Author

pelson commented Jul 5, 2012

This is a small-ish change if anyone is prepared to go over it?

@WeatherGod
Copy link
Member

I don't like how you do the string formatting of the 'b' variable separately from the formatting of the rest of the label. Why not do the string concatenation of the needed format string for the base and then do all the formatting at once?

@pelson
Copy link
Member Author

pelson commented Jul 21, 2012

I agree that it is a little awkward to follow. I'm not seeing your suggestion though, do you mean make base be either "%s" or "%d" and then use that for the string interpolation later on?

@WeatherGod
Copy link
Member

Yes. Do all the string formatting at once.

@pelson
Copy link
Member Author

pelson commented Jul 28, 2012

Ok @WeatherGod, I think this resolves your concern.

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

Looks good to me. Feel free to merge.

@WeatherGod
Copy link
Member

Right, thanks for that. Merging...

WeatherGod added a commit that referenced this pull request Aug 3, 2012
Fixed logformatting for non integer bases.
@WeatherGod WeatherGod merged commit 797940f into matplotlib:master Aug 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Formatter for tick labels can't handle non-integer base
3 participants