Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcolormesh edgecolor of "None" #999

Closed
pelson opened this issue Jul 10, 2012 · 2 comments
Closed

pcolormesh edgecolor of "None" #999

pelson opened this issue Jul 10, 2012 · 2 comments

Comments

@pelson
Copy link
Member

pelson commented Jul 10, 2012

#901 implemented a direct check that the edgecolor was not "None", but this excludes the use of "none" (or any other case derivative):

import numpy
import matplotlib.pyplot as plt

plt.subplot(121)
plt.pcolormesh(numpy.arange(12).reshape(3, 4), edgecolors='none')
plt.subplot(122)
plt.pcolormesh(numpy.arange(12).reshape(3, 4), edgecolors='None')
plt.show()

Please consider implementing case insensitive equivalent behaviour.

@mdboom
Copy link
Member

mdboom commented Jul 10, 2012

I don't think #901 introduced this -- it removed a check (which was case sensitive) and allowed it to pass through to another part of the library (which is also case sensitive). I'm not sure I consider this a bug -- most things in matplotlib are case sensitive.

@efiring
Copy link
Member

efiring commented Jul 15, 2012

The relevant code appears to be in Collection.set_edgecolor, which converts everything to lower case. Although in general I prefer case-sensitivity, there are exceptions, and this is one; it is just too hard to remember that something should be "None", and something else should be "none". So, as far as I can see, things are working in a reasonable fashion.

@efiring efiring closed this as completed Jul 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants