checkable pan/zoom buttons for QT NavigationToolbar #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -497,6 +497,7 @@ def __init__(self, canvas, parent, coordinates=True): | |||
| """ coordinates: should we show the coordinates on the right? """ | |||
| self.canvas = canvas | |||
| self.coordinates = coordinates | |||
| self._actions = {} | |||
There was a problem hiding this comment.
It's not immediately clear to a reader what this dictionary represents. A sphinx style docstring would be great here:
self._actions = {}
"""A dictionary mapping action names to button instances...."""
I leave the actual contents of the docstring to you.
There was a problem hiding this comment.
Thanks for the feedback -- I've amended with a docstring
|
Looks good to me. +1 |
|
I my eyes, this is ready for merging. The only question is whether it goes in before or after the 1.2 cut. |
|
I think after. |
pelson
added a commit
that referenced
this pull request
Sep 13, 2012
checkable pan/zoom buttons for QT NavigationToolbar
|
Thanks @ChrisBeaumont for this enhancement. I've merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small tweak makes the pan and zoom toolbar buttons "checkable" within the QT backend. This adds some shading around the active navigation mode button, which I find to be a bit clearer than the status bar message.
The check states are re-synchronized at each call to NavigationToolbar2QT.pan and NavigationToolbar2QT.zoom.