Uses tight_layout.get_subplotspec_list to check if all axes are compatible w/ tight_layout #1170
Conversation
… all the axes are supported by tight_layout
|
|
||
| subplot_axes = [ax for ax in self.axes if isinstance(ax, SubplotBase)] | ||
| if len(subplot_axes) < len(self.axes): | ||
| if None in get_subplotspec_list(self.axes): | ||
| warnings.warn("tight_layout can only process Axes that descend " | ||
| "from SubplotBase; results might be incorrect.") |
There was a problem hiding this comment.
@mdboom wanted to replace "descend" with "inherit" in the warning text.. you could change that in this PR so mdboom doesn't have to do it
There was a problem hiding this comment.
But with this change, the warning itself is now incorrect and must be fixed. @leejjoon, should it say something like "This figure includes Axes that do not inherit from SubplotBase and/or were not created using axes_locator; tight_layout will not take such Axes into account, so its results might be incorrect."
|
Can all this be simplified by having an Axes attribute to indicate whether tight_layout is supported? The attribute would be set to True whenever an operation creates a suitable Axes, or perhaps (if this is possible) modifies an existing Axes in such a way as to support tight_layout? |
|
While I agree that we need to simplify this, I don't have good solution for now. I will think about it, and any suggestion will be welcomed. |
Uses tight_layout.get_subplotspec_list to check if all axes are compatible w/ tight_layout
|
This is at least an interim solution, so I merged it. |
An axes that uses axes_locator (even though the axes itself is not an instance of SubplotBase) can be compatible with tight_layout. This PR suppresses warning message for such case.