PEP8 fixes on transforms.py #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -468,6 +474,7 @@ def fully_containsy(self, y): | |||
| :attr:`y1`. | |||
| """ | |||
| y0, y1 = self.intervaly | |||
| # FIXME x is not define. This method probably doesn't work. | |||
There was a problem hiding this comment.
Thanks. We should look into this in another issue - we might be able to get rid of the method all together.
There was a problem hiding this comment.
Oups... I was meaning to look into that before doing the PR, but I forgot...
There was a problem hiding this comment.
It's ok. If/when this PR gets merged, I (or whoever) can open an issue on it and sort it for v1.3.
|
+1 good stuff. |
|
Ditto +1. |
dmcdougall
added a commit
that referenced
this pull request
Oct 11, 2012
PEP8 fixes on transforms.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 fixes on the module transforms.
Thanks,
N