Fix typo in transforms.py #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the real question is, if it doesn't work, what is it doing here? Is it still useful to somebody? If not, we should delete it... |
|
Additionally, presumably this is broken in the 1.2 release, and should probably be applied there if we are going to fix it. |
|
Obviously it isn't used in any thing exercised by the test suite or we would have found it. But it is "technically" a public API. I'm more inclined to fix this than to remove it -- at least in 1.2.x. I'm going to go ahead and cherry-pick this onto 1.2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1364.
All the tests had been passing before this change, so I guess it doesn't look like it's being used.