Fix savefig.extension == "auto" #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discovered in #1530, though this doesn't fix the main bug in that report. |
|
@mdboom Cheers! |
|
@mdboom Are you happy for this to be merged or do you want to rebase to trigger a re-build? |
|
I'm going to rebase and let Travis (hopefully) check this. Assuming that passes, I think this is good to go. |
…) matplotlibrc, it will be copied into "savefig.format", where "auto" is not a supported choice. This will fix it so it becomes "png" if it's currently set to "auto". This bug discovered as part of matplotlib#1530, though it doesn't fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
savefig.extensionwas deprecated and replaced withsavefig.format. However,savefig.extensionsupported "auto" as a value, which the user may still have in their matplotlibrc. When converting it over tosavefig.format, the "auto" value should be converted to "png".