Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS X Backend: Removing clip that is no longer needed #1562

Merged

Conversation

mdehoon
Copy link
Contributor

@mdehoon mdehoon commented Dec 5, 2012

Same thing as for the Cairo backend (pull request #1538). The same simplifications can be made in the Mac OS X backend.

@mdboom
Copy link
Member

mdboom commented Dec 5, 2012

@mdehoon: Do you think this may have something to do with #1563?

@mdehoon
Copy link
Contributor Author

mdehoon commented Dec 5, 2012

No that is a separate issue.

@dmcdougall
Copy link
Member

Thanks @mdehoon. Do we have tests for the OS X infrastructure? If not, it'd be nice if, as a larger more ambitious goal, the C/C++/Objc code got code coverage. Though, having said that, this might be a moot point if we decide to make the move towards a Cython-backed infrastructure.

@mdehoon
Copy link
Contributor Author

mdehoon commented Dec 6, 2012

No we don't have specific tests for the Mac OS X backend. Realistically speaking I don't think I will find time to write such tests, but I wouldn't object if somebody else does.
Even if we do go towards a Cython-backed infrastructure, I think it would be a really bad idea to convert the Mac OS X backend to Cython. For one thing, it's hard to have the event loop, ObjC memory management, and Python reference counting play nice with each other. I don't want to add Cython to the mix. Also, let's not fix what is not broken.

dmcdougall added a commit that referenced this pull request Dec 9, 2012
Mac OS X Backend: Removing clip that is no longer needed
@dmcdougall dmcdougall merged commit b77afc6 into matplotlib:master Dec 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants