Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG flip when svg.image_noscale is True #1674

Merged
merged 1 commit into from Jan 18, 2013

Conversation

dmcdougall
Copy link
Member

Fixes #1673.

Not sure if this is the correct solution, but it appears to work for me, and all the tests pass locally with py27.

@tkanmae
Copy link
Contributor

tkanmae commented Jan 17, 2013

Thanks! It worked for me. Since the line h,w = im.get_size_out() appears right after the if clause, it seems better to move the line above the if clause and delete the one after the if clause.

@dmcdougall
Copy link
Member Author

@tkanmae Yes, you are correct. I will move it. Thank you.

@dmcdougall
Copy link
Member Author

I rebased so as not to create an unnecessary commit.

@mdboom
Copy link
Member

mdboom commented Jan 17, 2013

Looks good to me. I wonder if we should add an image comparison test for the noscale case.

@dmcdougall
Copy link
Member Author

Hm, moving the im.get_size_out() line above the if broke the output. I'll look into this...

@dmcdougall
Copy link
Member Author

@tkanmae So, there is a call to im.resize(numcols, numrows) at the end of the if block what messes with w, h, so I had to put it back. It works now.

@tkanmae
Copy link
Contributor

tkanmae commented Jan 18, 2013

Sorry, I missed the point. Hope it will soon get merged.

dmcdougall added a commit that referenced this pull request Jan 18, 2013
Fix SVG flip when svg.image_noscale is True
@dmcdougall dmcdougall merged commit 5a88d93 into matplotlib:v1.2.x Jan 18, 2013
@dmcdougall dmcdougall deleted the fix_svg_flip branch January 18, 2013 00:58
@tkanmae tkanmae mentioned this pull request Jan 20, 2013
@mdboom
Copy link
Member

mdboom commented Jan 23, 2013

Great work for a pretty serious bug. @dmcdougall : Like the new avatar, btw.

@dmcdougall
Copy link
Member Author

@mdboom ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants