New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added QtGui.QMainWindow.closeEvent() to make sure the close event #1678
Conversation
Hmmm. On master my test_bbox_inches tests pass, but with your patch one of them fails. This is locally. Strange. Edit: And it's the same diff as we remarked here |
cascades up properly. issue matplotlib#1676
@@ -370,6 +370,7 @@ def idle_draw(*args): | |||
class MainWindow(QtGui.QMainWindow): | |||
def closeEvent(self, event): | |||
self.emit(QtCore.SIGNAL('closing()')) | |||
QtGui.QMainWindow.closeEvent(self,event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PEP8 compliancy, can you add a space after the comma?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that. That habit has not fully taken yet.
re-based to master (to avoid On master, I get failures on test_arraw_ptachs.test_fancyarrow.test (1 error, 2 failures) which looks like issues with size of the output images. I get the exact same failures with this patch.
|
@tacaswell Yes, I have reported the issue in #1681, and it's nothing to do with this patch. I'll merge this now. Thanks. |
added QtGui.QMainWindow.closeEvent() to make sure the close event
added QtGui.QMainWindow.closeEvent() to make sure the close event
cascades closeEvents up properly.
issue #1676
I am not sure if there is a testable issue that shows up with out this patch, but this my understanding of good practice when over-riding functions in sub-classed QT classes.
I will look for any issues that show up without this.