Step linestyle #1802
Step linestyle #1802
Conversation
| @@ -1187,3 +1187,30 @@ def test_eb_line_zorder(): | |||
| if __name__=='__main__': | |||
There was a problem hiding this comment.
Not sure what you mean here. My editor removes white space at the end of lines when it saves so this looks like an un-intentional pep8 fix to me.
There was a problem hiding this comment.
the code if __name__ == "__main__" is duplicated in this file. It should be at the bottom of the file only, and not in the middle of the module. As you added it again after your code, you need to remove line 1187 to line 1189.
There was a problem hiding this comment.
right, I was looking at the wrong bit of code.
|
Sorry about the style issues. |
|
The 2.6 failure is related to pip and pyparsing |
|
The build error looks to just be a networking timeout. Typical for travis. |
| @@ -4793,7 +4793,8 @@ def step(self, x, y, *args, **kwargs): | |||
| if where not in ('pre', 'post', 'mid'): | |||
| raise ValueError("'where' argument to step must be " | |||
| "'pre', 'post' or 'mid'") | |||
| kwargs['linestyle'] = 'steps-' + where | |||
| ln_sty = kwargs.pop('linestyle', '') | |||
There was a problem hiding this comment.
I think this variable would benefit from a more explicite name.
There was a problem hiding this comment.
What would be a more explicit name? (I think there is some level of judgement here as I thought that was already a pretty explicit name). I have no problem changing it, I would just like to only change it once ;)
There was a problem hiding this comment.
Maybe something like linestyle if it is not already taken :)
There was a problem hiding this comment.
I guess I am (probably unjustly) paranoid about shadowing/trampling existing variables. How about usr_linestyle which makes me happy and makes it clear that this is the part of the linestyle that the user passed in, not the total linestyle that will be passed to plot
|
Apart from my last tiny nitpick, this looks good to me: 👍 |
|
@NelleV done |
|
I am not sure why it is failing, I will look into this later tonight. |
`linestyle` that is passed to `plot` instead of silently ignoring it.
|
The failure is due to what looks like a few pixel shift of the entire figure in the png output that I suspect is from the change is c64d0c25668b08cda4c19bb0c3c7ebfa56e47afe (based on the large number of image updates that go along with it). At any rate, rebased and replaced the offending test image. |
|
and if I had been thinking I would have also squashed some of those commits out of existence while I was re-writing history, but oh well. |
|
Nice. The only thing to add is probably a changelog entry to users now they can now do this. |
|
👍 Nice work. |
Looked at this because of http://stackoverflow.com/questions/15188005/linestyle-in-matplotlib-step-function/15191183#15191183
The
stepfunction is just a light wrapper ofplot. Added a step to append the user specifiedlinestyleonto the argument passed toplotinstead of silently ignoring it.Includes a unit test (there is currently no other test-coverage of
step).Based this against master because I am not sure if this is really a bug, or if I am changing an intentional interface.