New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported datetimes with microseconds, and those with long time series (>160 years). #1925
Conversation
|
||
def __call__(self): | ||
'Return the locations of the ticks' | ||
self.refresh() | ||
return self._locator() | ||
|
||
def nonsingular(self, vmin, vmax): | ||
# whatever is thrown at us, we can scale the unit. | ||
# But default nonsigular date plots at an ~4 year period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: nonsigular => nonsingular
Thanks @NelleV - I've added a commit which addresses your comments. |
LGTM 👍 for merge ! |
@@ -573,6 +577,11 @@ def _get_interval(self): | |||
return 1 | |||
|
|||
def nonsingular(self, vmin, vmax): | |||
""" | |||
Given the proposed upper and lower extent, adjust the range | |||
if it is too close to being singlular (i.e. a range of ~0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: singular
Thanks @efiring - I've done all of the above. The dates module is also now completely pep8 compliant. I think this is good to go. |
There are some Travis failures here, but once those are resolved, I think this looks good. |
I've updated the failing test result (and removed the formats which are not exercising anything new). |
Again, I think this is good for merge. |
Supported datetimes with microseconds, and those with long time series (>160 years).
This pull request updates the AutoDateLocator and AutoDateFormatter classes to handle extreme time series (
<1
second and>160
years).The follow code demonstrates the problems:
(try running this before this PR to see the improvement)