Fix bug in SpanSelector, introduced in commit #dd325759 #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The useblit attribute was being set after calling new_axes, but new_axes needs that attribute. By setting useblit before calling new_axes, we set it based on the initial canvas; even though new_axes might change to a different canvas, we assume it will be the same type of canvas (same backend), so its supports_blit attribute will not change.
pelson
added a commit
that referenced
this pull request
May 7, 2013
Fix bug in SpanSelector, introduced in commit dd32575
|
@efiring: Thanks for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The useblit attribute was being set after calling new_axes,
but new_axes needs that attribute. By setting useblit before
calling new_axes, we set it based on the initial canvas; even
though new_axes might change to a different canvas, we assume
it will be the same type of canvas (same backend), so its
supports_blit attribute will not change.