Make wx and wxagg work with wx 2.9.x on Mac. #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a data point, this works fine with wx 2.8.12 on my Linux box. Any testers with wx 2.8 on their Mac? It seems harmless enough... |
|
@efiring: I'm fine with merging this now and then hopefully using the release candidate as an excuse for more users to test this and find issue if any. So feel free to merge if you agree. |
This affects the wx* backends on OSX only. It removes Mac-specific code that was letting the Frame manage the toolbar directly, without using the Sizer. There was a comment saying that this was needed for OSX 10.3. With wx 2.9.x, however, this method of handling the toolbar does not work at all; no toolbar appears, and the program can hang or otherwise behave erratically. The Sizer method, however, works. The big question is whether the Sizer method works on the Mac with wx 2.8.x. If it does, then this can be merged.
|
@mdboom, I added a commit to delete a comment line, squashed, and force-pushed; but github does seem to be hung (checking for ability to merge), so I won't try to merge yet. |
|
I saw something like that elsewhere a few minutes ago, but it did seem to eventually update after about 15 minutes. They must be live coding on the site again ;) |
efiring
added a commit
that referenced
this pull request
May 24, 2013
Make wx and wxagg work with wx 2.9.x on Mac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects the wx* backends on OSX only. It removes Mac-specific
code that was letting the Frame manage the toolbar directly, without
using the Sizer. There was a comment saying that this was needed
for OSX 10.3. With wx 2.9.x, however, this method of handling
the toolbar does not work at all; no toolbar appears, and the
program can hang or otherwise behave erratically. The Sizer
method, however, works.
The big question is whether the Sizer method works on the Mac
with wx 2.8.x. If it does, then this can be merged.