PdfPages: add option to delete empty file when closed #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PdfPages objects can be told at initialization to delete the pdf file when closed, if no page was actually plotted - keep the default to not delete empty pdf files so current behavior is not changed - also some basic tests for it
| pdf.savefig() | ||
| assert os.path.exists(filename) | ||
| os.remove(filename) | ||
| with NamedTemporaryFile(delete=False) as tmp: |
There was a problem hiding this comment.
the comment in line 75 covers both blocks actually, but you're right maybe, I can split it up for clarity.
|
I've refactored docstrings for PdfPages, maybe somebody can give it a quick double check if its correct with MEP10. |
|
Looks good to me. |
mdboom
added a commit
that referenced
this pull request
Sep 30, 2013
PdfPages: add option to delete empty file when closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have automatic signal processing scripts with nested loops that output plots in multipage pdfs.
Sometimes, though, these loops do not produce a single pdf page and I ended up with loads of broken/empty pdf files. I found it useful to be able to tell the
PdfPageobject at initialization (usingwithstatement) that it should go straight to trash if it ends up empty.I wasn't sure if this was to be considered too special to go into the main repo but I figured opening a PR can't hurt too much. Also, the current behavior (keep empty pdf files)
when closed, if no page was actually plotted
not changed