Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8 clean up #2458

Merged
merged 2 commits into from Sep 30, 2013
Merged

pep8 clean up #2458

merged 2 commits into from Sep 30, 2013

Conversation

tacaswell
Copy link
Member

file seems to have been created with indentation of 3 spaces!

@megies
Copy link
Contributor

megies commented Sep 24, 2013

I still get some pep8 errors on that file, just in case you don't mind more pep8ing..

inset_locator.py:1:80: E501 line too long (82 > 79 characters)
inset_locator.py:23:80: E501 line too long (102 > 79 characters)
inset_locator.py:40:80: E501 line too long (80 > 79 characters)
inset_locator.py:41:80: E501 line too long (80 > 79 characters)
inset_locator.py:71:50: E128 continuation line under-indented for visual indent
inset_locator.py:72:50: E128 continuation line under-indented for visual indent
inset_locator.py:100:19: E127 continuation line over-indented for visual indent
inset_locator.py:111:50: E128 continuation line under-indented for visual indent
inset_locator.py:112:50: E128 continuation line under-indented for visual indent
inset_locator.py:118:80: E501 line too long (82 > 79 characters)
inset_locator.py:241:80: E501 line too long (81 > 79 characters)
inset_locator.py:242:80: E501 line too long (87 > 79 characters)
inset_locator.py:252:17: E127 continuation line over-indented for visual indent
inset_locator.py:253:17: E127 continuation line over-indented for visual indent
inset_locator.py:254:17: E127 continuation line over-indented for visual indent
inset_locator.py:255:17: E127 continuation line over-indented for visual indent
inset_locator.py:264:32: E128 continuation line under-indented for visual indent
inset_locator.py:283:24: E127 continuation line over-indented for visual indent
inset_locator.py:284:24: E127 continuation line over-indented for visual indent
inset_locator.py:285:24: E127 continuation line over-indented for visual indent
inset_locator.py:286:24: E127 continuation line over-indented for visual indent
inset_locator.py:295:32: E128 continuation line under-indented for visual indent
inset_locator.py:298:80: E501 line too long (100 > 79 characters)

@tacaswell
Copy link
Member Author

Right, I forgot I had the long-line flag squelched on my pyflakes (I am not a fan of the strict 80 char limit, it leads to stupid things like lines 41 and 42).

We ignore E127 and E128 in test_coding_standards.py so I will not fix those.

Didn't fix the first line beacuse every file now has that at the top and it should be dealt with in-bulk.

@megies
Copy link
Contributor

megies commented Sep 25, 2013

Well, I think E127 and E128 make sense most of the times and we're respecting them in our own projects. If the initial indent is getting too far right for the general rule of aligning with the bracket, there is the alternate rule for not putting anything after the bracket and going with a single indent.. e.g. for line 41:

38         super(AnchoredLocatorBase, self).__init__(
39             loc, pad=0., child=None, borderpad=borderpad,
40             box_to_anchor=bbox_to_anchor, box_transform=bbox_transform)

But of course, I do not know the specific rules for handling pep8 in matplotlib too well and I certainly do not want to sound nit-picky and like I just want to upend them for the fun of it. So no offense meant..
Just saw a couple more complaints from flake8 and thought I'd mention them.

@tacaswell
Copy link
Member Author

@megies No worries. Sorry if I came across as dismissive or hostile. I didn't want to not address issues you raised without explanation.

@pelson
Copy link
Member

pelson commented Sep 25, 2013

👍

mdboom added a commit that referenced this pull request Sep 30, 2013
@mdboom mdboom merged commit 9f72865 into matplotlib:master Sep 30, 2013
@tacaswell tacaswell deleted the mpl_inset_locater_pep8 branch August 14, 2014 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants