New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pep8 clean up #2458
pep8 clean up #2458
Conversation
I still get some pep8 errors on that file, just in case you don't mind more pep8ing..
|
Right, I forgot I had the long-line flag squelched on my pyflakes (I am not a fan of the strict 80 char limit, it leads to stupid things like lines 41 and 42). We ignore E127 and E128 in Didn't fix the first line beacuse every file now has that at the top and it should be dealt with in-bulk. |
Well, I think E127 and E128 make sense most of the times and we're respecting them in our own projects. If the initial indent is getting too far right for the general rule of aligning with the bracket, there is the alternate rule for not putting anything after the bracket and going with a single indent.. e.g. for line 41: 38 super(AnchoredLocatorBase, self).__init__(
39 loc, pad=0., child=None, borderpad=borderpad,
40 box_to_anchor=bbox_to_anchor, box_transform=bbox_transform) But of course, I do not know the specific rules for handling pep8 in matplotlib too well and I certainly do not want to sound nit-picky and like I just want to upend them for the fun of it. So no offense meant.. |
@megies No worries. Sorry if I came across as dismissive or hostile. I didn't want to not address issues you raised without explanation. |
👍 |
file seems to have been created with indentation of 3 spaces!