Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2542 #2544

Merged
merged 3 commits into from Nov 8, 2013
Merged

Fix 2542 #2544

merged 3 commits into from Nov 8, 2013

Conversation

pwuertz
Copy link
Contributor

@pwuertz pwuertz commented Oct 24, 2013

This PR fixes #2542 by first adding the capstyle and joinstyle properties to matplotlib.patches.Patch and setting the default capstyle of the axes spines to 'projecting'.

test

@mdboom
Copy link
Member

mdboom commented Oct 24, 2013

Great. Would you mind adding or modifying a regression test that does something like what your image example above does?

@pwuertz
Copy link
Contributor Author

pwuertz commented Oct 25, 2013

I've got a problem with the image comparison tests. Two of the low-dpi image tests are failing due to an artifact from the pdf to png conversion process. On the left you see the PDFs with and without the capstyle modifications. On the right are the PNGs produced by the image comparison test.
mpl_pdf_renderer
I suppose making changes to the PDF comparison toolchain is a bit out of scope. Although they look odd, shall I just commit the new images as test reference for now?

@pwuertz
Copy link
Contributor Author

pwuertz commented Nov 8, 2013

@mdboom: I think this PR is ready to merge if you are ok with it.

I modified an existing test to workaround PDF rendering issues, updated some baseline images and added a new test for the new spine capstyle. The commits are rebased to the current master.

@mdboom
Copy link
Member

mdboom commented Nov 8, 2013

Thanks so much for getting to the bottom of this. This is awesome.

mdboom added a commit that referenced this pull request Nov 8, 2013
@mdboom mdboom merged commit c91589c into matplotlib:master Nov 8, 2013
@pwuertz pwuertz deleted the fix_2542 branch November 8, 2013 20:03
@tacaswell
Copy link
Member

Should this be cherry-picked to 1.3?

@pwuertz
Copy link
Contributor Author

pwuertz commented Feb 4, 2014

There is no real API change, so probably yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual glitch in Axes borders
3 participants