New layout for qt4 subplottool + QMainWindow -> QDialog

[twmr]

This supersedes the subplottool part from #2112.

[tacaswell]

This needs a re-base.

Not sure if this should be addressed here or in #2112 but we should be using new-style QT signal/slots (see the discussion in #2382). This undoes all of those changes and will re-introduce the issues fixed in #2382

👎 on merging in it's current state.

[twmr]

@tacaswell rebased + use new style qt signals

[tacaswell]

We only have this one other place in the code base, is there a policy on this? @mdboom

[twmr]

There are 4 occurrences of __author__ in the mpl codebase

examples/api/sankey_demo_old.py:__author__ = "Yannick Copin <ycopin@ipnl.in2p3.fr>"
examples/user_interfaces/interactive.py:__author__ = "Fernando Perez <Fernando.Perez@colorado.edu>"
examples/user_interfaces/svg_histogram.py:__author__="david.huard@gmail.com"
lib/matplotlib/sankey.py:__author__ = "Kevin L. Davies"

[tacaswell]

I would argue that the examples are not part of the library proper (as they are stand alone examples of using the library)

[tacaswell]

@thisch Awesome, thanks!

I am a little concerned about two non-code things (both of which may be me worrying too much):

• @rhoef has been cut out of the commit logs entirely. Fixing that would require completely re-writing history to replace the first commit of this branch with a squashed version of the New subplottool and various fixes #2112 branch.
• What is the license on files created with pyuic? I think it is clean, but IANAL.

[twmr]

@tacaswell: Put @rhoef back into the commit logs (by squashing the #2112 branch)

[efiring]

I just tested this quickly on my machine, and it looks very nice. Just one glitch: the label on the "tight layout" button is misspelled (starts with "th" instead of "t").

[twmr]

@efiring fixed typo