Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gtk3 crash when running inside of IPython #2646

Merged
merged 1 commit into from Dec 13, 2013

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Dec 4, 2013

As reported in #2624, the Gtk3 backends and IPython are not playing well together, and either no window is displayed, or Python exceptions or even segfaults are thrown.

This, along with ipython/ipython#4640 seem to make everyone happy.

@tacaswell
Copy link
Member

Sorry for the poor issue reporting on this.

I don't know what you think the likely timeline on #2624 is, but would it be possible to hold off on merging this until after that one (just to avoid a re-base where I have to think).

@mdboom
Copy link
Member Author

mdboom commented Dec 4, 2013

I think we're likely to have a complicate merge and/or rebase regardless, since this is on v1.3.x...

@efiring
Copy link
Member

efiring commented Dec 4, 2013

Given that this is a 1-line deletion, I don't see a major problem. One way to handle it would be to merge this in 1.3.x, and then just make the equivalent change in the refactor PR.

@tacaswell
Copy link
Member

Ah, I missed what branch it was against.

The problem is that the change is now in a different file which, from re-basing to get rid of the QT4Agg functions, I found git does not deal with super gracefully. As Eric says this won't involve too much thinking, ignore my complaints.

tacaswell added a commit that referenced this pull request Dec 13, 2013
Fix Gtk3 crash when running inside of IPython
@tacaswell tacaswell merged commit 2b68a6c into matplotlib:v1.3.x Dec 13, 2013
@mdboom mdboom deleted the gtk3-crash branch August 7, 2014 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants