BUG: quiverkey must set the vector figure attribute #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failures on 3.2 are unrelated to this PR. |
tacaswell
added a commit
that referenced
this pull request
Feb 2, 2014
BUG: quiverkey must set the vector figure attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, quiverkey would fail at the drawing stage because the figure for the vector PolyCollection was not set. Bisection indicated that the problem started with
SHA: b8726d0,
but I haven't figured out why that triggered it; it seems like was an underlying bug in any case.
I added a test to test_quiver, and simplified the two existing tests that were already there.