Don't call Py_DECREF on null in _ttconv.cpp #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang's static checker noted that if PyBytes_FromString returns NULL (presumably rare) then Py_DECREF gets called on NULL; throw an exception instead. Also assert that the char* inputs are not NULL, since the Python API functions don't usually check that.
mdboom
added a commit
that referenced
this pull request
Apr 19, 2014
Don't call Py_DECREF on null in _ttconv.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang's static checker noted that if PyBytes_FromString returns NULL
(presumably rare) then Py_DECREF gets called on NULL; throw an
exception instead. Also assert that the char* inputs are not NULL,
since the Python API functions don't usually check that.