Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating PyQt version checks for v4.10+ #3022

Merged
merged 1 commit into from May 18, 2014

Conversation

davidia
Copy link

@davidia davidia commented Apr 29, 2014

@mdboom
Copy link
Member

mdboom commented Apr 30, 2014

When was the new API added? How far back will the new code work? (We may need to keep both working for a period of time).

@jenshnielsen
Copy link
Member

I have checked that the "new" API works on an RHEL 6 box with QT and PyQt based of version 4.6.2

@tacaswell tacaswell added this to the v1.4.0 milestone May 17, 2014
@tacaswell tacaswell merged commit 5cbc914 into matplotlib:master May 18, 2014
@tacaswell
Copy link
Member

I have failed to find an old version of the pyqt docs, but here: http://pyqt.sourceforge.net/Docs/PyQt4/qtcore.html#PYQT_VERSION_STR-var is the current docs. I would guess that something like that would be pretty stable and it is not listed in the possible incompatibility list. I suspect this is how we should have been doing it all along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyQt4 installation check fails as pyqtconfig is no longer built by default
4 participants