Use autolim kwarg in add_collection to prevent duplication of effort. #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset cleans up several problems associated with updating Axes.dataLim. The basic point is that when a method that creates a collection also updates Axes.dataLim, Axes.add_collection() should be called with autolim=False. With autolim=True, add_collection will use a very general method to update the dataLim, but in many cases the method creating the collection can perform the update much more efficiently. Closes matplotlib#3095, which reported a regression that appears to have been introduced by 88b722f.
| @@ -4301,9 +4301,10 @@ def get_interp_point(ind): | |||
| XY2 = np.array([x[where], y2[where]]).T | |||
| self.dataLim.update_from_data_xy(XY1, self.ignore_existing_data_limits, | |||
| updatex=True, updatey=True) | |||
| self.ignore_existing_data_limits = False | |||
There was a problem hiding this comment.
This flag is initialized to True by cla(); subsequently, anything that updates the dataLim needs to set it to False so that the updating is cumulative rather than starting again from scratch.
tacaswell
added a commit
that referenced
this pull request
Jun 2, 2014
Use autolim kwarg in add_collection to prevent duplication of effort.
| @@ -5032,7 +5033,7 @@ def pcolormesh(self, *args, **kwargs): | |||
| corners = (minx, miny), (maxx, maxy) | |||
| self.update_datalim(corners) | |||
| self.autoscale_view() | |||
| self.add_collection(collection) | |||
| self.add_collection(collection, autolim=False) | |||
There was a problem hiding this comment.
I think the better solution (but not the quicker solution, so I'm happy this PR was merged) would be to implement an appropriate data limit updater on the QuadMeshCollection - I'm not sure I'll get around to doing this anytime soon, so just wanted to post it here as a reminder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset cleans up several problems associated with updating
Axes.dataLim. The basic point is that when a method that creates
a collection also updates Axes.dataLim, Axes.add_collection() should be
called with autolim=False. With autolim=True, add_collection will
use a very general method to update the dataLim, but in many cases
the method creating the collection can perform the update much more
efficiently.
Closes #3095, which reported a regression that appears to have been
introduced by 88b722f.