Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type1font.py work better on Python 3.x #3203

Merged
merged 1 commit into from Jul 11, 2014

Conversation

jkseppan
Copy link
Member

@jkseppan jkseppan commented Jul 9, 2014

Communicate token types as objects instead of strings from the
tokenizer to the parser. Use proper Unicode strings for string-like
data in the font properties. Fix the handling of delimiters.

Resolves #3049.

Communicate token types as objects instead of strings from the
tokenizer to the parser. Use proper Unicode strings for string-like
data in the font properties. Fix the handling of delimiters.

Resolves matplotlib#3049.
@tacaswell
Copy link
Member

This seems fine to me, but I don't understand enough of the nuances of strings to be sure.

@mdboom
Copy link
Member

mdboom commented Jul 11, 2014

Looks good to me. I've restarted the errored Travis test, and once that passes, I think this is good to go.

tacaswell added a commit that referenced this pull request Jul 11, 2014
Make type1font.py work better on Python 3.x
@tacaswell tacaswell merged commit 6374332 into matplotlib:master Jul 11, 2014
@jkseppan jkseppan deleted the issue-3049 branch July 11, 2014 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF Embedded fonts with python3 mpl reported as 'Unknown' by pdffonts and pdf readers
4 participants