New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop make.py removing generated documentation figs #3253
Conversation
We should probably update the sphinx layout and replace the make.py file with a "real" makefile at some point. I think that just copying the default sphinx makefile "just works". |
Wow, @dmcdougall. Thanks for getting to the bottom of that. Ouch. |
@NelleV That would be great. It'd also mean we can get a parallel doc build out of the box. Right now the @mdboom Ouch indeed. I think removing these lines is ok, since everything is generated in the It'd be really helpful if someone could try out this PR as a sanity check and make sure a few of the broken links (listed in #2908) work as expected. |
Also, the reason I didn't use the |
Here's the output from
From 82 errors to one error, so I think this is probably good to merge. |
:woot!: |
Stop make.py removing generated documentation figs
And that error makes sense because you have not also built the pdf. |
Can we make linkchecker a part of the release procedure or maybe for On Wed, Jul 16, 2014 at 4:46 PM, Thomas A Caswell notifications@github.com
|
@tacaswell Correct, I didn't build the latex, only the html. @WeatherGod LinkChecker is GPL'd; I know not of the consequences of shipping LinkChecker with matplotlib. Instead of shipping it, we could do some foo to detect if LinkChecker is installed and, if so, use it to test the docs. I'd like to see that get run in the Travis builds. Documentation only takes 10 minutes to build. |
There is also a |
Oh yeah -- I forgot I saw that fly by. I think we're fine licensing-wise to install LinkChecker on Travis and use it. That would get us most of the way there. |
I think this fixes #2908. Links seem to work locally now.