Fix scaling of custom markers [backport to 1.4.x] #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also #3441.
tacaswell
changed the title
|
👍 Ideally, this should also have a regression test, based on the example in #3441. |
|
@mdboom I am not sure that makes sense. The bug is only in the example not in the library. |
|
Doh! you're right, @jenshnielsen |
|
Merged to manually resolve conflicts as 1c11929 |
|
cherry-picked with yet more whitespace conflicts as 3f19e75 I am beginning to think that @dopplershift is right and the massive pep8 clean up is causing more harm than good (at least in the short term). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #3441.