Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win fix simple #3503

Merged
merged 2 commits into from Sep 12, 2014
Merged

Win fix simple #3503

merged 2 commits into from Sep 12, 2014

Conversation

jbmohler
Copy link
Contributor

here are two simple fixes culled from #3409 in the efforts to focus the review. I probably shouldn't have batched those items together (not sure of protocol now that I did).

@tacaswell
Copy link
Member

I could have sworn that link got fixed already...

@jbmohler
Copy link
Contributor Author

I can only sigh about that fat-fingered link :)

@tacaswell
Copy link
Member

I will merge these as soon as travis passes.

For the other PR just re-base it on top of new v1.4.x head and force-push back to your gh branch.

@tacaswell
Copy link
Member

Actually, this made me go back and look at #3477 (which I just cherry-picked back to 1.4.x).

Does that extra searching work on windows to find png.h?

@jbmohler
Copy link
Contributor Author

No, the extra searching doesn't work on windows. It actually seems that somebody was trying to do something nice (maybe?) with a win32_static pseudo basedir. That may be worth my while for making the windows build slicker overall, but I think it is outside the scope of this PR.

The getstatusoutput code added in 04f13a4 fails on windows for multiple reasons and this PR restores the effective non-check as it happened on windows before that commit.

@tacaswell
Copy link
Member

ah, fair enough.

tacaswell added a commit that referenced this pull request Sep 12, 2014
BLD : restore non-searching for libpng on windows
@tacaswell tacaswell merged commit 71ba349 into matplotlib:v1.4.x Sep 12, 2014
@jbmohler jbmohler deleted the win_fix_simple branch October 20, 2014 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants