Provide an informative error message if something goes wrong in setfont [backport to 1.4.x] #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me. Going to need cherry-picking magic to bring it over to the 1.4.x branch. |
tacaswell
changed the title
|
Looks good to me. |
tacaswell
added a commit
that referenced
this pull request
Sep 22, 2014
MNT : Provide an informative error message if something goes wrong in setfont
tacaswell
added a commit
that referenced
this pull request
Sep 22, 2014
MNT : Provide an informative error message if something goes wrong in setfont
|
Cherry-picked as a62e7f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Five minutes to update the code, one hour fighting with github.